search

eclipse-aaspe / package-explorer

AASX Package Explorer
Other
55 stars 20 forks source link

Abstract "DataElement" in List of creatable SubmodelElements #149

Open keiligch opened 1 year ago

keiligch commented 1 year ago

Describe the bug In Package Explorer when adding a new SubmodelElement via "add other", in the pop up window there is the entry "DataElement" selectable. "DataElement" is declared abstract by specification and should not appear there. When adding "DataElement" to the SM / SMC, there is an empty entry, which is not deletable due to the lack of all buttons and text in the Element Details window on the right side. The parent (the SM / SMC) also cannot be clicked anymore to view the details.

To Reproduce Steps to reproduce the behavior:

  1. Go to arbitrary Submodel or Submodel Element Collection
  2. Click on 'add other ...' in the Submodel Element Editing Section
  3. Click on 'DataElement' and 'Select'
  4. Click on the created 'DataElement' and the parent SM / SMC to get an error log message and an incorrect behavement of the right details window

Expected behavior DataElement not appearing in the SubmodelElement list

Screenshots If applicable, add screenshots to help explain your problem.

Desktop:

BirgitBoss commented 9 months ago

There are more abstract SubmodelElements in the list like EventElement. So probably it is really better to remove the abstract SubmodelElement Classes from the list.