search

eclipse-aaspe / package-explorer

AASX Package Explorer
Other
44 stars 12 forks source link

Usage of outdated terms in the Asset Interfaces Description Submodel for branch https://github.com/admin-shell-io/aasx-package-explorer/tree/MIHO/TMV30_SAMM_Xmas2023 #17

Open AlexanderWollbrink opened 5 months ago

AlexanderWollbrink commented 5 months ago

From aasx-package-explorer created by Kaz040: admin-shell-io/temp-aasx-package-explorer#130

Issue Description

I was looking at branch created under this link to implement the Asset Interfaces Description Submodel concept. in the AidModbusConnection.cs file. the term modbus_type, modbus_function has been changed to modv_type and modv_function respectively. other term related to modbus has also been changed in the final release version of the document. below is a table of all the changes made across the AID submodel.

Changes in AID for existing terms

# IdShort (Term) Parent(s) Protocol Specific What changed result
1 created Interface SMC No SemanticID http://purl.org/dc/terms/created
2 modified Interface SMC No SemanticID http://purl.org/dc/terms/modified
3 support Interface SMC No SemanticID https://www.w3.org/2019/wot/td#supportContact
4 base EndpointMetadata SMC No SemanticID https://www.w3.org/2019/wot/td#baseURI
5 scheme SecurityDefinitions SMC No SemanticID https://www.w3.org/2019/wot/security#SecurityScheme
6 InterfaceMetadata InterfaceSMC No idShort InteractionMetadata
7 InterfaceMetadata InterfaceSMC No SemanticID https://admin-shell.io/idta/AssetInterfacesDescription/1/0/InteractionMetadata
8 modbus_function forms SMC Yes --> MODBUS idShort modv_function
9 modbus_function forms SMC Yes --> MODBUS SemanticID https://www.w3.org/2019/wot/modbus#hasFunction
10 modbus_type forms SMC Yes --> MODBUS idShort modv_type
11 modbus_type forms SMC Yes --> MODBUS SemanticID https://www.w3.org/2019/wot/modbus#hasPayloadDataType
12 modbus_entity forms SMC Yes --> MODBUS idShort modv_entity
13 modbus_entity forms SMC Yes --> MODBUS SemanticID https://www.w3.org/2019/wot/modbus#hasEntity
14 modbus_pollingTime forms SMC Yes --> MODBUS idShort modv_pollingTime
15 modbus_pollingTime forms SMC Yes --> MODBUS SemanticID https://www.w3.org/2019/wot/modbus#hasPollingTime
16 modbus_timeout forms SMC Yes --> MODBUS idShort modv_timeout
17 modbus_timeout forms SMC Yes --> MODBUS SemanticID https://www.w3.org/2019/wot/modbus#hasTimeout
18 modbus_zeroBasedAddressing forms SMC Yes --> MODBUS idShort modv_zeroBasedAddressing

New Terms included in AID

# IdShort (New Term) Parent(s) Protocol Specific SemanticID
1 modv_mostSignificantByte EndpointMetadata SMC and forms SMC Yes --> MODBUS https://www.w3.org/2019/wot/modbus#hasMostSignificantByte
2 modv_mostSignificantWord EndpointMetadata SMC and forms SMC Yes --> MODBUS https://www.w3.org/2019/wot/modbus#hasMostSignificantWord

Also The expected value for modv_type has changed from something like "uint32be" to just xsd datatypes like xs:float, xs:integer etc. Lastly, a new term has been introduced to denote endianness(modv_mostSignificantByte) and word swapping (modv_mostSignificantWord) .These information can be found in the final document

so the code snapshot below that is in AidModbusConnection.cs shoould be updated so that it won't break things when people start using the branch.

image