eclipse-aaspe / package-explorer

AASX Package Explorer
Other
64 stars 19 forks source link

[BUG] Handover Plugin creates invalid properties #193

Closed WelliSolutions closed 4 weeks ago

WelliSolutions commented 8 months ago

Describe the bug The handover plugin creates invalid properties named Document{0:00}, DigitalFile{0:00} and Language{0}.

To Reproduce

  1. Create a new AASX file or load an existing one.
  2. Set the workspace to edit mode
  3. Select an AAS
  4. Make sure it does not have a documentation submodel already.
  5. Select Workspace/Create/New submodel from plugin
  6. Choose AasxpluginDocumentShelf|Document (recommended version)
  7. Select the DOC plugin
  8. Select "V1.0"
  9. Click "Add Document"
  10. Click "Update to AAS"
  11. Bug: it creates a SMC named Document{0:00}, which should be Document00 instead
  12. Select "V1.1"
  13. Click "Add Document"
  14. Add a language to "Languages"
  15. Add a file to "DigitalFile"
  16. Click "Update to AAS"
  17. Bug: it creates a property Language{0} which should be Language00 instead.
  18. Bug: it creates a file DigitalFile{0:00} which should be DigitalFile00 instead.

Expected behavior The plugin creates correct names (see above)

Screenshots Document{0:00}

DigitalFile{0:00}

Desktop (please complete the following information): Windows 10 22H2

Smartphone (please complete the following information): N/A

Additional context Version 2024-02-27

MichaelHoffmeisterFesto commented 6 months ago

Thank you for the very detailed description of the case!

Current branch name: MIHO/Post_XMAS2023_Bugfixes

MichaelHoffmeisterFesto commented 4 weeks ago

Checked again, seems to work. All over in AASPE, as well as in "How to write a SMT specification", the change to

__00__

is being explained.