search

eclipse-aaspe / package-explorer

AASX Package Explorer
Other
41 stars 12 forks source link

[BUG]Data specification IEC61360 id does not work due to case sensitivity. #196

Open JS-Aibel opened 3 months ago

JS-Aibel commented 3 months ago

Describe the bug According to “IDTA-01003-a-3-0_SpecificationAssetAdministrationShell_Part3a_DataSpecification_IEC61360”, the id of the Data Specification IEC61360 Template is https://admin-shell.io/DataSpecificationTemplates/DataSpecificationIec61360/3/0 By using the id, an error message in the Package Explorer (v2024-02-27) is saying that the Data specification Reference could not be identified. Thus, no content attributes could be provided.

Expected behavior By changing the letters IEC in the id to uppercase, Package Explorer is showing the attributes as expected. https://admin-shell.io/DataSpecificationTemplates/DataSpecificationIEC61360/3/0

juileetikekar commented 1 month ago

Hi @JS-Aibel,

Could you please provide steps to reproduce, respective logs and screenshots for this issue?

JS-Aibel commented 1 month ago

Hi, @juileetikekar

  1. Create a Concept Description with HasDataSpesification of type “DataSpecificationIEC61360”.

image

  1. When changing ids, make sure to save the file to see the effect.

The difference between the two ids is the uppercase letters EC in the word DataSpecificationIEC61360.

MichaelHoffmeisterFesto commented 1 month ago

Hello,

thanks for reporting this bug! It seems to be pretty severe. According to the latest spec, it is not only about case-mismatch of "IEC" vs "Iec", but also the scheme changed from scheme "http://" to "https://" (Spec 01003-a-3-0 from March 2023). I would assume, that the Package Explorer implemented the (pre-liminary) URI and the spec changed this during the process without noticing. As a result, I assume that a large number of wrong data specs are now in the wild.

For the current branch (MIHO/Post_XMAS2023_Bugfixes) I've now changed this. The AASPE uses the correct URI as a preset and takes both variants ("http://" and "https://") with case-insensitive matching.

BirgitBoss commented 1 month ago

Please also see this issue for the specification of the data specification itself: https://github.com/admin-shell-io/aas-specs-iec61360/issues/2#issuecomment-1864303829 We will provide a bugfix allowing both variants, with http and https. But probably we missed the Iec and IEC part.