eclipse-aaspe / server

C# based server for AASX packages
Other
72 stars 52 forks source link

Refactoring the Startup.cs and Program1.cs #229

Closed Freezor closed 6 months ago

Freezor commented 8 months ago

Description

This PR aims to refactor the Program1.cs and Startup.cs files in the project. The original files were confusing and did not adhere to Clean Code or SOLID principles, making it difficult to understand the server's behavior. The changes are intended to improve clarity and maintainability, as well as to lay the groundwork for future enhancements.

Motivation and Context

The motivation behind this change is to enhance the codebase by following best practices and establishing a clearer structure. By refactoring the code, we aim to improve understanding, maintainability, and scalability of the project.

This PR includes the following changes:

Type of change

How Has This Been Tested?

These changes have been tested locally by running the application and verifying that it starts up successfully without any errors. Additionally, manual inspection of the refactored code has been performed to ensure correctness and adherence to the intended changes.

Screenshots (if appropriate):

N/A

Checklist:

CLAassistant commented 8 months ago

CLA assistant check
All committers have signed the CLA.

Freezor commented 8 months ago

Hi @juileetikekar thanks for the review, but I'm still not able to merge. Can you help me with that?

juileetikekar commented 8 months ago

Hi @Freezor,

Thank you very much for the PR.

However, in my opinion, there are some checks missing in the PR. I have already asked @martafullen and @AlexanderWollbrink to look into it. In summary, I am waiting for their response, before I merge the PR into main.