Closed Freezor closed 6 months ago
Hi @juileetikekar thanks for the review, but I'm still not able to merge. Can you help me with that?
Hi @Freezor,
Thank you very much for the PR.
However, in my opinion, there are some checks missing in the PR. I have already asked @martafullen and @AlexanderWollbrink to look into it. In summary, I am waiting for their response, before I merge the PR into main.
Description
This PR aims to refactor the
Program1.cs
andStartup.cs
files in the project. The original files were confusing and did not adhere to Clean Code or SOLID principles, making it difficult to understand the server's behavior. The changes are intended to improve clarity and maintainability, as well as to lay the groundwork for future enhancements.Motivation and Context
The motivation behind this change is to enhance the codebase by following best practices and establishing a clearer structure. By refactoring the code, we aim to improve understanding, maintainability, and scalability of the project.
This PR includes the following changes:
Program1.cs
toBlazorServerStarter
for better readability and to avoid confusion with the existingProgram
class.BlazorServerStarter
to simplify the understanding of the server initialization process.DependencyRegistry.cs
and server configuration intoServerConfiguration.cs
fromStartup.cs
.ServerConfiguration.cs
into smaller parts, adhering to Clean Code and SOLID principles.Type of change
How Has This Been Tested?
These changes have been tested locally by running the application and verifying that it starts up successfully without any errors. Additionally, manual inspection of the refactored code has been performed to ensure correctness and adherence to the intended changes.
Screenshots (if appropriate):
N/A
Checklist: