search

eclipse-aaspe / server

C# based server for AASX packages
Other
72 stars 52 forks source link

[Bug]: Same submodel IDs from different AAS #232

Open psapel opened 7 months ago

psapel commented 7 months ago

Contact Details

patrick.sapel [ at ] ikv.rwth-aachen.de

Describe the bug

When multiple AAS are equipped with a submodel having the same identifier, the statement /shells/{aasIdentifier}/submodels/{submodelIdentifier} will only retrieve the data from the first AAS on the server that includes this submodel, regardless of the specified aasIdentifier.

Meaning:

To reproduce and Expected Behaviour

To reproduce, you can use the demo server and the two examples below: https://v3.admin-shell-io.com/swagger/index.html

  1. AAS SICK_AHM36B_S4QC012x12_1092017 /shells/ZGlnaXRhbC5zaWNrLmNvbS9zaGVsbHMvMTA5MjAxNw/submodels/ZGlnaXRhbC5zaWNrLmNvbS9zaGVsbHMvc3VibW9kZWxzL25hbWVwbGF0ZQ or aasIdentifier: ZGlnaXRhbC5zaWNrLmNvbS9zaGVsbHMvMTA5MjAxNw submodelIdentifier: ZGlnaXRhbC5zaWNrLmNvbS9zaGVsbHMvc3VibW9kZWxzL25hbWVwbGF0ZQ

Expected value for PROP ManufacturerProductDesignation = AHM36B-S4QC012x12 (correct)

  1. AAS SICK_SIG200_0A0412200_1089794 /shells/ZGlnaXRhbC5zaWNrLmNvbS9zaGVsbHMvMTA4OTc5NA/submodels/ZGlnaXRhbC5zaWNrLmNvbS9zaGVsbHMvc3VibW9kZWxzL25hbWVwbGF0ZQ or aasIdentifier: ZGlnaXRhbC5zaWNrLmNvbS9zaGVsbHMvMTA4OTc5NA submodelIdentifier: ZGlnaXRhbC5zaWNrLmNvbS9zaGVsbHMvc3VibW9kZWxzL25hbWVwbGF0ZQ

Expected value for PROP ManufacturerProductDesignation = SIG200-0A0412200 (but it displays AHM36B-S4QC012x12 )

Version

https://v3.admin-shell-io.com/swagger/index.html (08.04.2024) and AASX Server V3 2023-11-17.alpha

Thank you for your support!

juileetikekar commented 7 months ago

Hi @psapel,

Thank you for raising the issue!

Two different submodels with same identifiers coming from different AAS environments raise some open questions, e.g., if the submodels with already existing identifiers be allowed in the same server. etc.

We will come back to you on this with more information.

psapel commented 7 months ago

Thank you for quick response @juileetikekar

In my opinion, already existing Submodel identifier should be allowed on the same server as this is more practicable, e.g., for using identic "blueprint" submodels like technical data or nameplate multiple times within different AAS. In addition, it is possible to address a specific submodel uniquely using the combination of AAS-id and the correspondig SM-id.

However, I'm looking forward to your answer.