search

eclipse-agail / agile-core

Source code repository for agile core components
Eclipse Public License 2.0
7 stars 16 forks source link

update and test Hexiwear and Medical device code #82

Open cskiraly opened 6 years ago

cskiraly commented 6 years ago

See https://github.com/Agile-IoT/agile-core/issues/81

dpap commented 6 years ago

Medical device works if the abstract keyword is removed from the device definition. @csaba do you want a pull request? I am not sure why the class was abstracted in the first place?

cskiraly commented 6 years ago

In fact it wasn't abstract before. If you have the time, please look for the patch that made the change, to see if there are other things to undo (git blame might help). If not, just remove the abstract. Thanks

dpap commented 6 years ago

git log -L34,+1:MedicalDevice.java

It's been there a while ... It was probably done to force implementation of the new write functions

commit a7d4317a451a297e0d134f8177f5ae986e0be212 Author: koustabhdolui koustabh.here@gmail.com Date: Thu Oct 5 14:02:55 2017 +0200

Make device instance classes to implement write.
Implement Write function for TISensorTag

Signed-off-by: koustabhdolui <koustabh.here@gmail.com>

diff --git a/iot.agile.DeviceFactory/src/main/java/iot/agile/device/instance/HexiwearDevice.java b/iot.agile.DeviceFactory/src/main/java/iot/agile/device/instance/HexiwearDevice.java --- a/iot.agile.DeviceFactory/src/main/java/iot/agile/device/instance/HexiwearDevice.java +++ b/iot.agile.DeviceFactory/src/main/java/iot/agile/device/instance/HexiwearDevice.java @@ -33,1 +33,1 @@ -public class HexiwearDevice extends AgileBLEDevice implements Device { +public abstract class HexiwearDevice extends AgileBLEDevice implements Device {