search

eclipse-agail / agile-sdk

JavaScript Agile IoT SDK
Eclipse Public License 2.0
2 stars 4 forks source link

Security #23

Closed nopbyte closed 6 years ago

nopbyte commented 6 years ago

This PR includes the functionality to update the password for the user that is currently logged in, and for other users in the sdk. It also lints the code in the examples and removes unused variables.

nopbyte commented 6 years ago

@craig-mulligan, can you have another look please? thanks for the prompt review :)

craigmulligan commented 6 years ago

Oh also could you make sure to squash commits into a single commit before merging?

And make the message conform to template:

My new feature

Connects to #<issue-number>

Change-Type: minor
nopbyte commented 6 years ago

I did the changes for the spacing across my files. Could you please squash it and merge it please? I can squash the commits but I would prefer to merge directly (not rebase and then merge the PR) for simplicity.

The message I would recommend would be:

Adds the calls to reset and update user's password. Clean the details on the security calls to axios to comply with coding standards for the rest of the project and clean up examples.

There is no issue related to this update

craigmulligan commented 6 years ago

merged, tagged, published @nopbyte