search

eclipse-agail / agile-sdk

JavaScript Agile IoT SDK
Eclipse Public License 2.0
2 stars 4 forks source link

Accept relative uri as parameter for agile-core #34

Closed Exulansis closed 6 years ago

Exulansis commented 6 years ago

Reasoning behind this is described in #33 .

Change-Type: patch

Exulansis commented 6 years ago

As a side note, two more things to take into consideration:

  1. This would still not allow for paths like https://something.com/proxy/, but I assume that's not a concern.
  2. I am not 100% certain what behavior can be expected if a node application uses the sdk and supplies an endpoint such as /api/agile-core, the webSocketBase might be incorrect, because it's the origin of the app using the sdk with the protocol changed to ws. I think in this case the origin will end up being undefined.
craigmulligan commented 6 years ago

Published with 1.2.1