eclipse-apoapsis / .eclipsefdn

Repository to host configurations related to the Eclipse Foundation.
https://eclipse-apoapsis.github.io/.eclipsefdn/
1 stars 1 forks source link

ort-server: Update required checks #15

Closed mnonnenmacher closed 1 month ago

mnonnenmacher commented 1 month ago

This is required for 1.

eclipse-otterdog[bot] commented 1 month ago

This is your friendly self-service bot.

Thank you for raising a pull request to update the configuration of your GitHub organization. You can manually add reviewers to this PR to eventually enable auto-merging.

The following conditions need to fulfilled for auto-merging to be available:

Otterdog commands and options You can trigger otterdog actions by commenting on this PR: - `/otterdog team-info` checks the team / org membership for the PR author - `/otterdog validate` validates the configuration change - `/otterdog validate info` validates the configuration change, printing also validation infos - `/otterdog check-sync` checks if the base ref is in sync with live settings - `/otterdog merge` merges and applies the changes if the PR is eligible for auto-merging (only accessible for the author) - `/otterdog done` notifies the self-service bot that a required manual apply operation has been performed (only accessible for members of the admin team) - `/otterdog apply` re-apply a previously failed attempt (only accessible for members of the admin team)
eclipse-otterdog[bot] commented 1 month ago

This is your friendly self-service bot.

The author (mnonnenmacher) of this PR is associated with this organization in the role of MEMBER.

Additionally, mnonnenmacher is a member of the following teams:

eclipse-otterdog[bot] commented 1 month ago

This is your friendly self-service bot. Please find below the validation of the requested configuration changes:

Diff for 9ed2982fca98442df62a50e1e8a0bde56265bafe ```diff Organization technology.apoapsis[id=eclipse-apoapsis] ! repo_ruleset[name="main", repository="ort-server"] { ! required_status_checks = "['build', 'build-ui', 'commit-lint', 'detekt-issues', 'eslint', 'integration-test', 'prettier', 'renovate-validation', 'reuse-tool', 'test', 'website-test', 'wrapper-validation']" -> "['build', 'build-ui', 'commit-lint', 'detekt-issues', 'eslint', 'integration-test', 'prettier-ui', 'prettier-website', 'renovate-validation', 'reuse-tool', 'test', 'website-test', 'wrapper-validation']" ! } Plan: 0 to add, 1 to change, 0 to delete. ```
eclipse-otterdog[bot] commented 1 month ago

This is your friendly self-service bot. The current configuration is in-sync with the live settings. :rocket:

eclipse-otterdog[bot] commented 1 month ago

This is your friendly self-service bot. This Pull Request is eligible for auto-merging as it passed the following checks:

In order to automatically merge and apply the changes, add a comment /otterdog merge. :rocket:

netomi commented 1 month ago

I think to get the PR merged you first have to remove prettier as status check. Once the PR is merged, you can add the 2 new checks as they will only be executed once the workflows are present on the default branch.

Thats actually an annoying shortcoming of required status checks in branch protection rules / rulesets imho.

mnonnenmacher commented 1 month ago

/otterdog merge

eclipse-otterdog[bot] commented 1 month ago

This is your friendly self-service bot.

The following changes have been successfully applied:


Organization technology.apoapsis[id=eclipse-apoapsis]

!   repo_ruleset[name="main", repository="ort-server"] {
!     required_status_checks            = "['build', 'build-ui', 'commit-lint', 'detekt-issues', 'eslint', 'integration-test', 'prettier', 'renovate-validation', 'reuse-tool', 'test', 'website-test', 'wrapper-validation']" -> "['build', 'build-ui', 'commit-lint', 'detekt-issues', 'eslint', 'integration-test', 'prettier-ui', 'prettier-website', 'renovate-validation', 'reuse-tool', 'test', 'website-test', 'wrapper-validation']"
!   }

  Applying changes:

  Done.

  Executed plan: 0 added, 1 changed, 0 deleted.