feat: Make renovate-validation a required status check

[mnonnenmacher]

Make renovate-validation a required status check for the guidance and renovate repositories.

[eclipse-otterdog[bot]]

This is your friendly self-service bot.

Thank you for raising a pull request to update the configuration of your GitHub organization. You can manually add reviewers to this PR to eventually enable auto-merging.

The following conditions need to fulfilled for auto-merging to be available:

• valid configuration
• approved by a project lead
• does not require any secrets
• does not update settings only accessible via the GitHub Web UI
• does not remove any resource

Otterdog commands and options

You can trigger otterdog actions by commenting on this PR: - `/otterdog team-info` checks the team / org membership for the PR author - `/otterdog validate` validates the configuration change - `/otterdog validate info` validates the configuration change, printing also validation infos - `/otterdog check-sync` checks if the base ref is in sync with live settings - `/otterdog merge` merges and applies the changes if the PR is eligible for auto-merging (only accessible for the author) - `/otterdog done` notifies the self-service bot that a required manual apply operation has been performed (only accessible for members of the admin team) - `/otterdog apply` re-apply a previously failed attempt (only accessible for members of the admin team)

[eclipse-otterdog[bot]]

This is your friendly self-service bot.

The author (mnonnenmacher) of this PR is associated with this organization in the role of MEMBER.

Additionally, mnonnenmacher is a member of the following teams:

• technology-apoapsis-committers

• technology-apoapsis-project-leads

• technology-apoapsis-security

[eclipse-otterdog[bot]]

This is your friendly self-service bot. Please find below the validation of the requested configuration changes:

Diff for 6dcc2472e1441474017cea9f080bfbdab788f258

```diff Organization technology.apoapsis[id=eclipse-apoapsis] ! branch_protection_rule[pattern="main", repository="guidance"] { ! required_status_checks = [ + renovate-validation ! ] ! } ! branch_protection_rule[pattern="main", repository="renovate"] { ! required_status_checks = [ + renovate-validation ! ] ! } Plan: 0 to add, 2 to change, 0 to delete. ```

[eclipse-otterdog[bot]]

This is your friendly self-service bot. The current configuration is in-sync with the live settings. :rocket:

[eclipse-otterdog[bot]]

This is your friendly self-service bot. This Pull Request is eligible for auto-merging as it passed the following checks:

• valid configuration
• approved by a project lead
• does not require any secrets
• does not update settings only accessible via the GitHub Web UI
• does not remove any resource

In order to automatically merge and apply the changes, add a comment /otterdog merge. :rocket:

[mnonnenmacher]

/otterdog merge

[eclipse-otterdog[bot]]

This is your friendly self-service bot.

The following changes have been successfully applied:

Organization technology.apoapsis[id=eclipse-apoapsis]

!   branch_protection_rule[pattern="main", repository="guidance"] {
!     required_status_checks = [
+      renovate-validation
!     ]
!   }

!   branch_protection_rule[pattern="main", repository="renovate"] {
!     required_status_checks = [
+      renovate-validation
!     ]
!   }

  Applying changes:

  Done.

  Executed plan: 0 added, 2 changed, 0 deleted.

[mnonnenmacher]

@netomi FYI, looks like the diff for the required checks is working correctly now.

[netomi]

I think that is a case that was working before. It failed if the list was in a further nested structure like for a Ruleset. When we started we only supported shallow objects and their properties. This is much simpler but with the growing number of properties it gets confusing, so we have now support for further nesting to group properties that belong together, but not everything was adjusted for that afaict. Should be fixed now.