search

eclipse-apoapsis / ort-server

A scalable server implementation of the OSS Review Toolkit.
https://eclipse-apoapsis.github.io/ort-server/
Apache License 2.0
19 stars 8 forks source link

Move delete buttons for organizations, products, and repositories to settings #529

Open mnonnenmacher opened 4 months ago

mnonnenmacher commented 4 months ago

Move the delete functionality for organizations, products, and repositories to a new settings tab, similar to the "Danger Zone" in the GitHub repository settings. Deleting one of these entities should never happen accidentally as it could delete important data that cannot be recovered, so the alert dialog should require additional verification like typing out the entity name.

sschuberth commented 4 months ago

To me, moving the buttons and additional verification in the alert dialog are two different things. Do we really need to implement both, or is only the latter probably enough?

mnonnenmacher commented 4 months ago

To me deletion is a rare operation that should not be prominently shown on the default page but rather be hidden in the settings. But yes, the verification is more important.

mmurto commented 4 months ago

To me deletion is a rare operation that should not be prominently shown on the default page but rather be hidden in the settings.

I agree with this, spending screen real estate on something probably done so seldomly is not the best use of space.

sschuberth commented 4 months ago

is not the best use of space.

Which we have plenty of, though.

Etsija commented 4 months ago

Well what about editing of the said items: should that also be hidden in the settings?

mnonnenmacher commented 4 months ago

Well what about editing of the said items: should that also be hidden in the settings?

On the long term, probably yes. But to me not urgent at all.

sschuberth commented 2 months ago

Well what about editing of the said items: should that also be hidden in the settings?

Relates to https://github.com/eclipse-apoapsis/ort-server/issues/831.