Neubs bsi/update release appropriately/#588

neubs-bsi commented 3 years ago

Please provide a summary of your changes here.

Which issue is this pull request belonging to? (Refer to issue here)

How is it solving the issue?

Did you add or update any new dependencies that are required for your change?

It is solving the issue by introducing the option to merge the release gotten from the artifact with precedence when having the clearing state WIP and the release is not yet approved in any kind or form with precedence.

See commit messages for more detailed information.

Issue: #588

Request Reviewer

You can add desired reviewers here with an @mention.

@KorSin

Type of Change

Mention one of the following:
bug fix | new feature | improvements | documentation update | CI | Other

Type of change: bug fix

How Has This Been Tested?

If you have added any changes that require additional tests, or changes in tests, you should implement them and describe them here.
All test that passed before your contribution should pass after it as well.

Tests still pass, were adapted and some added.

Checklist

Must:

[x] All related issues are referenced in commit messages

Optional: (delete if not applicable)

[x] I have provided tests for the changes (if there are changes that need additional tests)
[x] I have updated the documentation accordingly to my changes

sonarcloud[bot] commented 3 years ago

SonarCloud Quality Gate failed.

0 Bugs
0 Vulnerabilities (and 0 Security Hotspots to review)
0 Code Smells

64.9% Coverage
0.0% Duplication

The version of Java (1.8.0_272) you have used to run this analysis is deprecated and we will stop accepting it accepting it soon.Please update to at least Java 11. Read more here

neubs-bsi commented 3 years ago

I'd actually not add the test, as I see no value in that specific test. The clearing state is tested in the metadataupdater, so at least part of the class should be covered.

KorSin commented 3 years ago

Looks good. Since it is the first time I review something from you, do you intend to squash some of the commits?

neubs-bsi commented 3 years ago

No, I think each commit stands for itself and builds. A squash should not be necessary.

eclipse-archived / antenna