search

eclipse-archived / antenna

SW360 Antenna project
Other
22 stars 19 forks source link

Added Maven Wrapper 3.6.3 #639

Closed ohbus closed 1 year ago

ohbus commented 3 years ago

Added Maven Wrapper

These files are from Maven wrapper. It works similarly to the Gradle wrapper.

This allows you to run the Maven project without having Maven installed and present on the path. It downloads the correct Maven version if it's not found (as far as I know by default in your user home directory).

The mvnw file is for Linux (bash) and the mvnw.cmd is for the Windows environment.

Should fix #579

neubs-bsi commented 3 years ago

Hello @ohbus , thanks for your contribution. As you might have seen in some places, we have a contribution guideline. Your commit messages do not describe why the changes are necessary. For example: https://github.com/eclipse/antenna/pull/639/commits/295d1ca46115d66802b99a114754a269e51513af refactored PR build behavior -> why is that better than before or why is it necessary.

Additionally I would like to ask you, to use the pull request template that comes with this repository. It should have automatically been there when you filed this PR.

ohbus commented 3 years ago

Hi @neubs-bsi, as I have linked the corresponding Issue against this Pull request I did not follow the template.

I apologize for this and would like to amend the necessary changes.

Thanks.

neubs-bsi commented 3 years ago

Hello @ohbus

We don't want merge commits in a PR, rather it's preferred to rebase master on the branch of the PR. Additionally, you have not re-written the commit messages. It is still not obvious why the changes would be better than the way it was before. Please amend the commit messages.

ohbus commented 3 years ago

@neubs-bsi done with your requests