search

eclipse-archived / californium.core

Californium project
86 stars 69 forks source link

Secure Client example #34

Closed allhateme closed 9 years ago

allhateme commented 9 years ago

An example of Secure Client for the exisisting Secure Server.

sophokles73 commented 9 years ago

@allhateme,

thanks for submitting the example for a secure client. In order for us to be able to merge the PR we need you to include a proper signed-off-by footer in the commit message. Can you add this?

Regards, Kai

allhateme commented 9 years ago

@sophokles73

i filled an LCA, Could you explain me how i can modify the commit in order to add signed-off-by line?

sophokles73 commented 9 years ago

You can use git commit --amend to edit the last commit message. Simply add the corresponding line (after a blank line) to the commit message. Then force push your branch to your git repo from where you created the PR.

allhateme commented 9 years ago

@sophokles73

i modified the commit message. What else have i to do?

Regards, Antonio

mkovatsc commented 9 years ago

It looks like you added the line by hand (others have a colon after "Signed-off-by"). Another problem might be that the author name and Signed-off-by name differ.

Let's try:

  1. Change your Git author name for this repo (git config user.name "Antonio Ciancio")
  2. Revert your master to de6f1932a19a948cedb073100520874a6133361e (before the merge)
  3. Amend you commit with the "-s" option (git commit --amend -s)
  4. Force-push again to your origin branch