search

eclipse-archived / californium.core

Californium project
86 stars 69 forks source link

Bugfix for #474290 (wrong payload length in tracing message of responses). #35

Closed boaks closed 9 years ago

boaks commented 9 years ago

Fixes bug #474290.

Additionally moves code duplicate from Request and Response to Message. Add textual tracing of block-options.

Signed-off-by: Achim Kraus achim.kraus@bosch-si.com

boaks commented 9 years ago

What line-endings are used in californium? Does the repository use windows line-endings?

mkovatsc commented 9 years ago

The code started out Windows line endings. In between we had a few commits with Unix endings, of which only a few were fixed. We need to settle this before 1.0, I would say. I start discussion on the mailing list. For the pull-request, I need the same line endings to have a proper diff. We can then convert all files to uniform endings, but that commit then must only touch the line endings.

mkovatsc commented 9 years ago

You could simply add a new commit to your branch that converts the line endings back. It will then appear here. No need to create a new pull-request (if that is what you plan :) ).

boaks commented 9 years ago

Too late ...