search

eclipse-archived / californium.core

Californium project
86 stars 69 forks source link

Bugfix of wrong payload length in message tracing for responses. #36

Closed boaks closed 9 years ago

boaks commented 9 years ago

Move common tracing code from Request and Response to Message. Add textual description for block option.

Signed-off-by: Achim Kraus achim.kraus@bosch-si.com

mkovatsc commented 9 years ago

The commit is fine except for a little code style issue: conditions in if statements should start in the same line as the closing brace. There also some extra spaces. (We use the default Eclipse code formatter, but without line length restriction.)

Simply commit to the same branch and it will end up here.

boaks commented 9 years ago

I'm wondering what you exactly mean by "conditions in if statements should start in the same line as the closing brace".

if (condition) { .... some } // closing brace

but how can the "condition" start at the line of the "closing brace"?

mkovatsc commented 9 years ago

Sorry, I meant all additional conditions (else if) and else like in Utils.java:75:

}
else {
mkovatsc commented 9 years ago

Thanks a lot for the contribution!