search

eclipse-archived / californium.core

Californium project
86 stars 69 forks source link

Mistake in OptionNumberRegistry.isCritical #57

Closed mojadita closed 8 years ago

mojadita commented 8 years ago

Signed-off-by: Luis Colorado lcu@basen.net

mojadita commented 8 years ago

I discovered this bug trying to integrate library on own code. As of reviewing more, I discovered more errors in the OptionNumberRegistry so I wrote several Unit tests to check all the options against RFC-7252 doc.

sophokles73 commented 8 years ago

Hi @mojadita,

thanks for your PR :-) We have merged californium.core, californium.scandium and californium.element-connector into the caifornium repo several weeks ago. Can you please re-open your PR against that repo (https://github.com/eclipse/californium)?

Thanks, Kai

mojadita commented 8 years ago

Ok... Thanks... I'll do it.

sbernard31 commented 8 years ago

Maybe we should change the master branch by just committing a README.md file to redirect to the right repository. Something like that ? https://github.com/jvermillard/leshan (if we want to keep the master just in case we can keep it in a oldmaster branch)

mkovatsc commented 8 years ago

+1 for README and oldmaster (also +1 for the fix, but that will only matter in the new PR :) )

sbernard31 commented 8 years ago

(ok I will do that for californium.core, californium.scandium and californium.element-connector)

mkovatsc commented 8 years ago

Okay, thanks! (There is already the "oldmaster" branch for californium.core ;) )