search

eclipse-archived / ceylon-herd

The Ceylon repository web application
Apache License 2.0
21 stars 11 forks source link

#96 Email modification confirmation #127

Closed fmeurisse closed 11 years ago

fmeurisse commented 11 years ago

No DB modification needed. I use the confirmation code column in the user_table as describe in the issue #96

thradec commented 11 years ago

How it is supposed to work? When I'm logged like common user (not admin), I can not edit my email in Edit your profile form, there is still message Email is not currently editable.

fmeurisse commented 11 years ago

I forgot to remove the help block. If you are admin user, you can modify your email without validation. If you are not admin, the register.skip.email != false, and you modify your email :

fmeurisse commented 11 years ago

I will fix it

fmeurisse commented 11 years ago

The fix is done and I remove my personnal configuration from application.conf

thradec commented 11 years ago

It works much better now, but I found some more tiny details...

fmeurisse commented 11 years ago

Done

2013/4/17 Tomas Hradec notifications@github.com

It works much better now, but I found some more tiny details...

  • it is possible to set empty email
  • confirmation email is sent to old address
  • and it would be nice, if in edit form, would be some information text, that change request was accepted, email sent and it is necessary to confirm it (or something similar)

— Reply to this email directly or view it on GitHubhttps://github.com/ceylon/ceylon-herd/pull/127#issuecomment-16525043 .

thradec commented 11 years ago

Merged with 12d9edec7509feb5c9d939ff032f4c9111900080. Thanks !!!