search

eclipse-archived / ceylon-herd

The Ceylon repository web application
Apache License 2.0
21 stars 11 forks source link

#126 Search result, should display more information #128

Closed fmeurisse closed 11 years ago

fmeurisse commented 11 years ago

Currently, the module owner can edit the module from the result list. I can modify the moduleTable tag to disable this functionnality.

thradec commented 11 years ago

Currently, the module owner can edit the module from the result list

It's fine by me.

FroMage commented 11 years ago

So, @thradec, is this now good to apply?

thradec commented 11 years ago

@FroMage No, in my opinion. The code should be optimized by introduction view-model (like you suggested) or at least add fetch joins into current search query ( or we can create separate issue for that ;-) ).

fmeurisse commented 11 years ago

I am modifying the search query with join fetch

2013/4/23 Tomas Hradec notifications@github.com

@FroMage https://github.com/FroMage No, in my opinion. The code should be optimized by introduction view-model (like you suggested) or at least add fetch joins into current search query ( or we can create separate issue for that ;-) ).

— Reply to this email directly or view it on GitHubhttps://github.com/ceylon/ceylon-herd/pull/128#issuecomment-16867840 .

thradec commented 11 years ago

Thanks man! (rebased and merged by fd8e51ed3c98b187528a73539856f5318134faa3)