search

eclipse-archived / ceylon-herd

The Ceylon repository web application
Apache License 2.0
21 stars 11 forks source link

Add votes #43

Closed FroMage closed 11 years ago

FroMage commented 12 years ago

Let users rate modules (or versions?). Not sure if we need them to be logged in…

quintesse commented 12 years ago

I'd say yes, otherwise you'd have to handle vote stuffing and such

fmeurisse commented 12 years ago

What about a star/unstar system like github repo ?

FroMage commented 12 years ago

star/unstar is different because it's about following modules. It is a very good idea though, but we should open another issue. This one is about rating modules.

thradec commented 11 years ago

@FroMage for this issue, there is few months old pull request #111

FroMage commented 11 years ago

Very good point. Can you rebase/review/test it please? It looks good to me but I didn't run it, and I suspect it needs a line in db/update-X.sql

thradec commented 11 years ago

Done (rebased and added some fixes and improvements)

FroMage commented 11 years ago

OK that looks good. I wouldn't have put the score in the comment form myself, but I guess this forces people to add a comment at the same time, which is useful. The right close arrow doesn't do anything though, is this normal?

thradec commented 11 years ago

The right close arrow doesn't do anything though, is this normal?

It cancel/annul your current module rating. (set number of stars to zero). Maybe better icon or description.

FroMage commented 11 years ago

It doesn't do anything in my case.

thradec commented 11 years ago

Interesting. Which browser? I tested it on chrome 26 and firefox 20.

FroMage commented 11 years ago

Chrome 24. What's supposed to happen when I press it? The current stars remain the same.

thradec commented 11 years ago

It should unstar current rating. All stars should be empty.

FroMage commented 11 years ago

OK fixed. It was because Chrome 24 does not let you register JS handlers on CSS-generated content.