Fix issue #56 - Githubissues

eclipse-archived / ceylon-herd

The Ceylon repository web application

Apache License 2.0

21 stars 11 forks source link

Closed glours closed 12 years ago

glours commented 12 years ago

Fix issue #56 - Add a menu entry "My modules" and a list of the user's modules

FroMage commented 12 years ago

Thanks a lot, but this time (for once) I have comments :)

glours commented 12 years ago

Sorry for the initial commit of the pull-request, I fought with Git and I lost ;)

FroMage commented 12 years ago

OK so you have three options here:

either you rebase those commits to rewrite them (advanced)
or you keep adding commits to the feature branch that fix the issues I raised (easy, that's what I advise)
or you start a new branch with a new pull request (longest)

In any case the commit you added helps, but you forgot to remove things as well once you moved them, so you need to add another commit to clean up.

FroMage commented 12 years ago

Merged it, thanks a lot