search

eclipse-archived / ceylon-herd

The Ceylon repository web application
Apache License 2.0
21 stars 11 forks source link

Issue #89 Check module dependencies on delete #92

Closed fmeurisse closed 11 years ago

FroMage commented 11 years ago

Thanks a lot, I'l try to integrate it on Monday, but I think that we should integrate this directly in the delete flow by including the error directly on the first remove confirmation page, with links to the dependent modules so that the user can directly navigate there, and just prevent the user from even going as far as remove2/3, as well as make the check in remove2/3 for security/integrity reasons.

If you feel like modifying your code then excellent, if not don't worry I can do that Monday :)

fmeurisse commented 11 years ago

I will try to do the modification before monday

2012/9/21 Stéphane Épardaud notifications@github.com

Thanks a lot, I'l try to integrate it on Monday, but I think that we should integrate this directly in the delete flow by including the error directly on the first remove confirmation page, with links to the dependent modules so that the user can directly navigate there, and just prevent the user from even going as far as remove2/3, as well as make the check in remove2/3 for security/integrity reasons.

If you feel like modifying your code then excellent, if not don't worry I can do that Monday :)

— Reply to this email directly or view it on GitHubhttps://github.com/ceylon/ceylon-herd/pull/92#issuecomment-8759091.

FroMage commented 11 years ago

Thanks a lot, merged it manually!