search

eclipse-archived / ceylon-herd

The Ceylon repository web application
Apache License 2.0
21 stars 11 forks source link

#47 categories administration. #93

Closed fmeurisse closed 11 years ago

fmeurisse commented 11 years ago

This commit adds a category admin section. A category is a name with a description.

Sql scripts are not updated.

gavinking commented 11 years ago

@fmeurisse Are these categories for modules?

fmeurisse commented 11 years ago

Yes, how I can link a pull request to an opened issue.

Fabien

Le 21 sept. 2012 à 23:28, Gavin King notifications@github.com a écrit :

@fmeurisse Are these categories for modules?

— Reply to this email directly or view it on GitHub.

gavinking commented 11 years ago

Yes, how I can link a pull request to an opened issue.

You just mention it like this #47.

So if we have module categories now, the IDE's Repository Explorer needs to also present things by category, I suppose.

fmeurisse commented 11 years ago

The categories are not yet linked to modules. A category is just a label and a module can have several categories or a category is a folder, a module has only one category ?

2012/9/22 Gavin King notifications@github.com

Yes, how I can link a pull request to an opened issue.

You just mention it like this #47https://github.com/ceylon/ceylon-herd/issues/47 .

So if we have module categories now, the IDE's Repository Explorer needs to also present things by category, I suppose.

— Reply to this email directly or view it on GitHubhttps://github.com/ceylon/ceylon-herd/pull/93#issuecomment-8786588.

FroMage commented 11 years ago

Good question. I guess we can start with a single category per module and no category hierarchy

FroMage commented 11 years ago

Merged manually. Thanks a lot, the code was very good :)

Just minor remarks:

I think we're still missing a page to browse modules by category, which means we need to turn the browse and modules into a sub-menu browse with three entries:

I also guess we should list the category description in the module page, as markdown, optionally expanded (like module doc), and category should also be present for module version page.

Let me know if what I mentioned interests you.

Thanks a lot!

fmeurisse commented 11 years ago

I will try to do these modifications this week.

2012/9/24 Stéphane Épardaud notifications@github.com

Merged manually. Thanks a lot, the code was very good :)

Just minor remarks:

  • In general I prefer edit links to be buttons (category view)
  • To check that a user is admin you need to use @Check("admin") on the controller
  • I added a link for admins from the module/edit page to the categories admin page, because that's generally useful
  • I modified the category/delete action to list the modules concerned by the deletion and to update them

I think we're still missing a page to browse modules by category, which means we need to turn the browse and modules into a sub-menu browse with three entries:

  • By name
  • By category
  • As file system

I also guess we should list the category description in the module page, as markdown, optionally expanded (like module doc), and category should also be present for module version page.

Let me know if what I mentioned interests you.

Thanks a lot!

— Reply to this email directly or view it on GitHubhttps://github.com/ceylon/ceylon-herd/pull/93#issuecomment-8817534.

FroMage commented 11 years ago

Excellent! :)

fmeurisse commented 11 years ago

You say:

"I think we're still missing a page to browse modules by category, which means we need to turn the browse and modules into a sub-menubrowse with three entries:

I don't really understand how you imagine this modification. I have already done the "by category" navigation

I have transformed the Modules link in the top nav bar to a dropdown menu with two items : "by name" and "by category". The by name link displays the module list as before and the second item shows the categories. For each categories, we can display the module list.

You want to move the Repository item in the Modules menu in an item named "As file system" ?

2012/9/24 Stéphane Épardaud notifications@github.com

Excellent! :)

— Reply to this email directly or view it on GitHubhttps://github.com/ceylon/ceylon-herd/pull/93#issuecomment-8817776.

FroMage commented 11 years ago

Yes :) Though perhaps we can make it As repository. Not sure which is clearer. I just expect that browsing it that way will be a lot less useful than by name/categ/search