search

eclipse-archived / ceylon.formatter

A formatter for the Ceylon programming language, written in Ceylon.
Apache License 2.0
14 stars 11 forks source link

spaceBeforeXxxOpeningParenthesis #88

Closed gavinking closed 9 years ago

gavinking commented 9 years ago

I can't see why we need five (5) different settings to control whether there is a space between a control structure keyword and its opening paren. Especially ironic is that even with 5 different knobs, we don't have complete coverage (switch is missing).

These should all be rationalized to a single switch.

lucaswerkmeister commented 9 years ago

JDT also has different options for the different control structures. Are you sure everyone wants to handle them the same?

gavinking commented 9 years ago

JDT also has different options for the different control structures.

Which helps make their formatter almost impossibe to configure.

Are you sure everyone wants to handle them the same?

I'm sure everyone non-crazy does, yes.

lucaswerkmeister commented 9 years ago

Okay, let’s merge them then.

lucaswerkmeister commented 9 years ago

Done. (The new option only applies between a keyword and an opening parenthesis; for example, it doesn’t apply to else.)