search

eclipse-archived / ceylon

The Ceylon compiler, language module, and command line tools
http://ceylon-lang.org
Apache License 2.0
399 stars 62 forks source link

Ceylon ant tasks share Launcher settings #1367

Open CeylonMigrationBot opened 11 years ago

CeylonMigrationBot commented 11 years ago

[@FroMage] This is more probably a bug in Launcher though, in that it it set up using settings from the first invocation and all further invocations will reuse the same instance and ignore subsequent settings that may be used for setting it up.

[Migrated from ceylon/ceylon-compiler#1367]

CeylonMigrationBot commented 11 years ago

[@FroMage] This one's for you @quintesse.

CeylonMigrationBot commented 11 years ago

[@FroMage] It is only marginally related to #1366 that I just fixed.

CeylonMigrationBot commented 10 years ago

[@quintesse] Well the thing is the Launcher was specifically made for this, to be able to set up the class loader specifically for Ceylon. And the reason to re-use the same class loader was because if you try creating a new class loader for each invocation you run out of memory real soon (on my system after 15-20 invocations).

So I'm not really sure what to do about this one. The easier solution for now is to just make forked invocations possible for all ant tasks and worry about in-process later.

CeylonMigrationBot commented 10 years ago

[@FroMage] Is this still relevant @quintesse ?

CeylonMigrationBot commented 10 years ago

[@quintesse] Well since you fixed #1366 there's at least a correct way of doing things. For in-process ant compile tasks this would still be a problem. But like I mentioned before, I'm not sure what can be done about this. Maybe check if the Launcher is called with incompatible arguments and try to reset things. Or keep classloaders associated with the associated arguments and re-use them when called with the same arguments and create new ones if the arguments are different. Leave this open for now. I'll investigate a bit more.

CeylonMigrationBot commented 10 years ago

[@quintesse] Moving to 1.2