Closed Voiteh closed 4 years ago
After a (very) quick review, I concur with the changes up to b24025c. In that range, I didn't notice any compatibility breaks and the only new feature appears to be the relatively harmless addition of transpose()
Could someone check: bd03712
, 1232190
, 60327c2
, c5d2fc7
this is implementation of #7218, although #7218 is not annotated as breaking change I'm not sure if we would have backward compatiblity with that issue onboard
Incomplete list of commits to (at least partially) revert:
parseBoolean
's arg changed to String?
; need to review others in #7012 as well)Regarding the meta model syntax changes https://github.com/eclipse/ceylon/issues/7460#issuecomment-589959787, I suspect that although unwanted, they are fine.
Note that there could still be documentation issues or new bugs - I don't know if any website or other doc changes were made, and didn't check to see if there are tests for the new syntax. But given that at least the old syntax seems to work, that's probably good enough for our limited goals.
I'll change commit description as accepted
dfc3bc1887, 6798efd00e, 02223051bd, 0c7a6e460c, 06859f0486, 13742e5d62, db53d11903 <---- This guys are for #7220 I dont see any breaking label on the ticket but according to description this will introduce new syntax deprecating old one. Old one will rise warning. I guess wee don't want that for 1.3.4 ??
As long as the new let
syntax support doesn't break anything, I think we are fine.
Ideally there wouldn't be new features or warnings, but given the difficulty of rolling back commits made before the package renames and IP transfer to Eclipse, rollbacks should be a last resort. And if the future is to use the let
keyword, I think we might as well keep the warning on the use of value
.
1.3.4 can't happen due to Eclipse package naming requirements
This issue hold information on what has been reviewed and needs to be reviewed before 1.3.4 release can happen. To contribute take a commit from list located below refering to https://github.com/eclipse/ceylon/tree/_old/master branch You can search commits on github by
https://github.com/eclipse/ceylon/commit/{commitID}
Important aspect is to exlclude braking changes so we don't include them into release. After review include information. a) what have been reviewed, b) the sort of things You were looking for c) a list of commits You are concerned about and the reasonList will be updated with new comments
@NotNull
if
rather than via declared variable afterif
ceylon/ceylon-examples-web
to the RELEASE document