Closed mattcolegate closed 4 years ago
Merging #467 into master will not change coverage. The diff coverage is
n/a
.
@@ Coverage Diff @@
## master #467 +/- ##
=======================================
Coverage 20.99% 20.99%
=======================================
Files 61 61
Lines 5121 5121
=======================================
Hits 1075 1075
Misses 3918 3918
Partials 128 128
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update f351483...827142f. Read the comment docs.
Signed-off-by: Matthew Colegate colegate@uk.ibm.com
What type of PR is this ?
What does this PR do ?
This PR allows the
diagnostics
tool to get the correct versions for remote containers. The gatherCodewindVersions() function now takes a connectionID so that it can be passed to the existing GetContainerVersions() method to allow version retrieval for both remote and local connections. The additional GATEKEEPER version has been added to codewind.versions file for remote connections, and extra error handling has been put in so that end users will be able to clearly see why version information is not present if there has been a problem obtaining it.Which issue(s) does this PR fix ?
https://github.com/eclipse/codewind/issues/2798
Link to the Codewind repository issue(s) this PR fixes or references:
https://github.com/eclipse/codewind/issues/2798
Does this PR require a documentation change ?
No
Any special notes for your reviewer ?