Closed mattcolegate closed 4 years ago
Merging #469 into master will not change coverage. The diff coverage is
n/a
.
@@ Coverage Diff @@
## master #469 +/- ##
=======================================
Coverage 20.94% 20.94%
=======================================
Files 61 61
Lines 5132 5132
=======================================
Hits 1075 1075
Misses 3929 3929
Partials 128 128
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 6fb803d...1541409. Read the comment docs.
Thanks @stalleyj, recommendations implemented
Tested in various scenarios and I always get the version information or the appropriate error message.
What type of PR is this ?
What does this PR do ?
This PR enables the Docker Client & Server version strings to be written to the codewind.versions file created by running
cwctl diagnostics
for a local connection. The version strings are obtained using the docker client's getClientVersion() and getServerVersion() methods.Which issue(s) does this PR fix ?
Part fix for https://github.com/eclipse/codewind/issues/2793
Link to the Codewind repository issue(s) this PR fixes or references:
https://github.com/eclipse/codewind/issues/2793
Does this PR require a documentation change ?
No
Any special notes for your reviewer ?