Closed stalleyj closed 4 years ago
Merging #494 into master will decrease coverage by
0.06%
. The diff coverage is35.80%
.
@@ Coverage Diff @@
## master #494 +/- ##
==========================================
- Coverage 19.83% 19.77% -0.07%
==========================================
Files 80 81 +1
Lines 7014 7061 +47
==========================================
+ Hits 1391 1396 +5
- Misses 5453 5495 +42
Partials 170 170
Impacted Files | Coverage Δ | |
---|---|---|
pkg/project/filelist.go | 0.00% <0.00%> (ø) |
|
pkg/project/sync.go | 55.64% <46.77%> (-4.62%) |
:arrow_down: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update c5a6baf...476dd30. Read the comment docs.
Tested on Windows using recreation instructions from https://github.com/eclipse/codewind/issues/2860 - imported hello/Hello.java and project rebuilt and I was able to run the new application from the /hello endpoint
What type of PR is this ?
What does this PR do ?
This PR fixes our syncing behaviour to identify files that have been imported into the project via the Eclipse IDE. When a user does this, the modified time of the file does not get updated so our current sync checks for last mod time > last sync time don't pick up the new files.
The new behaviour looks to see if each file contained in the project (on the users disk) is in the list of files for the project (that have been uploaded to codewind). If that file doesn't exist, it will be uploaded.
Which issue(s) does this PR fix ?
https://github.com/eclipse/codewind/issues/2860
Does this PR require a documentation change ?
No
Any special notes for your reviewer ?
No