search

eclipse-archived / codewind-installer

The installation package for installing Codewind into an editor
https://codewind.dev
Eclipse Public License 2.0
5 stars 28 forks source link

TemplateRepo Auth pointer #497

Closed ebuckle closed 4 years ago

ebuckle commented 4 years ago

Signed-off-by: Edward Buckle edward.buckle0@gmail.com

What type of PR is this ?

What does this PR do ?

Change the type of Authentication in the TemplateRepo object to be a pointer. This enables omitempty to properly hide the field when it is not returned from PFE

Which issue(s) does this PR fix ?

https://github.com/eclipse/codewind/issues/3101

Link to the Codewind repository issue(s) this PR fixes or references:

Does this PR require a documentation change ?

No

Any special notes for your reviewer ?

None

codecov[bot] commented 4 years ago

Codecov Report

Merging #497 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #497   +/-   ##
=======================================
  Coverage   19.77%   19.77%           
=======================================
  Files          81       81           
  Lines        7061     7061           
=======================================
  Hits         1396     1396           
  Misses       5495     5495           
  Partials      170      170
Impacted Files Coverage Δ
pkg/utils/templates.go 12.28% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 50b3309...451bee7. Read the comment docs.