search

eclipse-archived / codewind-installer

The installation package for installing Codewind into an editor
https://codewind.dev
Eclipse Public License 2.0
5 stars 28 forks source link

Project Link - output original error from PFE if available #501

Closed james-wallis closed 4 years ago

james-wallis commented 4 years ago

NOTE: Should follow the PFE PR for the same issue

Signed-off-by: James Wallis james.wallis1@ibm.com

What type of PR is this ?

What does this PR do ?

Changes the error handling for Project linking to output the original error from PFE when it is available + in a known format. Refactor link tests to make them more manageable.

Which issue(s) does this PR fix ?

Link to the Codewind repository issue(s) this PR fixes or references: https://github.com/eclipse/codewind/issues/3149

Does this PR require a documentation change ?

Any special notes for your reviewer ?

codecov[bot] commented 4 years ago

Codecov Report

Merging #501 into master will increase coverage by 0.03%. The diff coverage is 78.57%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #501      +/-   ##
==========================================
+ Coverage   19.79%   19.82%   +0.03%     
==========================================
  Files          81       81              
  Lines        7063     7067       +4     
==========================================
+ Hits         1398     1401       +3     
- Misses       5495     5496       +1     
  Partials      170      170
Impacted Files Coverage Δ
pkg/project/project_utils.go 0.00% <ø> (ø)
pkg/project/link.go 80.00% <78.57%> (-0.29%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 56605fb...ad48956. Read the comment docs.