search

eclipse-archived / codewind-vscode

Extension for developing cloud-native, containerized applications from VS Code
https://codewind.dev
Eclipse Public License 2.0
16 stars 30 forks source link

Fix remove project #590

Closed tetchel closed 4 years ago

tetchel commented 4 years ago

Pls rebase and merge

commit 8bab7eeb4572d1a0dde794de992770e899ce96a5 (HEAD -> fixRemoveProject, origin/fixRemoveProject)
Author: Tim Etchells <timetchells@ibm.com>
Date:   Thu May 7 14:17:04 2020 -0400

    Fix case where the last ws folder is being removed

    Signed-off-by: Tim Etchells <timetchells@ibm.com>

commit 78e3b390a8f7b02bff595b92aa1ee105a5333c8e
Author: Tim Etchells <timetchells@ibm.com>
Date:   Wed May 6 18:23:49 2020 -0400

    Fix project removal behaviour, again

    - Remove workspace folder before attempting to delete files
        - Fixes https://github.com/eclipse/codewind/issues/2456
    - Add a warning message if the extension is going to reload due to a workspace folder change

    Signed-off-by: Tim Etchells <timetchells@ibm.com>

What type of PR is this ?

What does this PR do ?

Which issue(s) does this PR fix ?

Link to the Codewind repository issue(s) this PR fixes or references:

Does this PR require a documentation change ?

Any special notes for your reviewer ?