search

eclipse-archived / codewind-vscode

Extension for developing cloud-native, containerized applications from VS Code
https://codewind.dev
Eclipse Public License 2.0
16 stars 30 forks source link

Update Email notification #591

Closed josephca closed 4 years ago

josephca commented 4 years ago

What type of PR is this ?

What does this PR do ?

Remove unreachable steps within post-failure block.

Which issue(s) does this PR fix ?

https://github.com/eclipse/codewind/issues/1888

Link to the Codewind repository issue(s) this PR fixes or references:

Does this PR require a documentation change ?

Any special notes for your reviewer ?

tetchel commented 4 years ago

Please test this by throwing an error in an early build stage to make sure the fail condition works and that the email actually goes out, then overwrite the purposeful failure once we know it works.

josephca commented 4 years ago

Please test this by throwing an error in an early build stage to make sure the fail condition works and that the email actually goes out, then overwrite the purposeful failure once we know it works.

It was tested. Please review again.