Allow user to specify multiple docker registry credentials

[jopit]

If the user has an Appsody project with a custom stack/collection for which images are pushed to a registry other than Docker Hub, the project is unable to build because the codewind container does not have the credentials to login to internal docker registry to pull the required images.

To fix this, we need to allow the user to specify credentials for a number of image registries that PFE can use to pull the images.

See Codewind not able to work with stacks images in the internal registry/non-docker hub See Dynamic registry setup for the local scenario See [Hybrid] Create docker registry secret in kube

[jopit]

No way to tell if an Appsody project requires credentials to access the associated docker registry.

Hybrid & Che

• User needs to specify zero or one docker registries to for Codewind projects to push images to
• User needs to specify zero or more docker registries for Appsody projects to pull stack images from

Local

• User needs to specify zero or more docker registries for Appsody projects to pull stack images from

The registry to push Codewind projects to may or may not also be a registry to pull Appsody stacks from.

[jopit]

Hybrid & Che

• When the user first creates a codewind project, prompt for the docker registry needed for push

Local, Hybrid & Che

• Add an item to the connection's context menu to show a 'manage container registries' page which allows user's to add, remove and edit the list of registries that PFE knows about. The list should also contain the registry needed for push if it exists. The user should be able to change which registry is used for the push from this page.

[makandre]

When users enter the registry credentials in the IDEs, I'd like to propose that we do a local docker login as well; this would serve 2 purpose:

• we can make sure the creds work before posting them to PFE
• a successful login makes the creds available to local docker for pulling (this is for appsody init which happens locally)

[j-c-berger]

Feel free to assign me @micgibso and @sishida

[tetchel]

here's the existing page which will be mostly out of date after 0.7 https://www.eclipse.org/codewind/dockerregistry.html

[tetchel]

merged https://github.com/eclipse/codewind-vscode/pull/323

[eharris369]

@j-c-berger @sishida There is a "Learn more" link in the Manage Registries dialog that needs a URL for the documentation for this feature. Can you give us a URL even if the documentation is not complete yet so we can update the code?

[sishida]

@eharris369 This is the main Docker registry file that I am aware of: https://www.eclipse.org/codewind/dockerregistry.html

If we want to use this link, we should add a new section about specifying multiple Docker registry credentials. We could also link directly to this new section.

[tetchel]

Steps 1 and 2 in the linked page are invalid now and should be replaced by the new documentation

[eharris369]

Should the examples use the same terms as in the IDEs? Address for host (docker.io) and namespace for the <username> part of docker.io/<username>?

(Feel free to suggest improvements to any of the strings in the above dialog.)

[sishida]

I generally lean on the side of consistency. So unless there's a reason to change up the terms, my vote is for using the same terms. :)

Also, here are some minor edits:

• "Provide registries for projects that need to pull content to build. You can designate a single registry as a push registry."
  • The desktop checker recommends "to" instead of "in order to" because it's less wordy.
  • I also changed the second sentence to active voice.
• "Username" should be one word unless it's already two words throughout Eclipse.

[j-c-berger]

@jopit, as always, thank you for the detailed and spot-on feedback! Looking forward to progressing with this issue.

@tetchel, question regarding your comment on steps 1 and 2 for the dockerregistry doc: https://www.eclipse.org/codewind/dockerregistry.html

Do we want to replace steps 1 and 2 with the content that I'm developing now? Basically, this issue will focus on dockerregistry and update those steps? Or, will I be making a whole new doc for this issue (as we earlier discussed) and update dockerregistry? In which case, I can open a second issue for the latter since there will be two separate docs being worked on. Thanks!

[maysunfaisal]

@j-c-berger with regards to the question addressed to @tetchel, I have put a comment on PR https://github.com/eclipse/codewind-docs/pull/261/files#r357857126

Steps 1 and 2 needs to be merged, because they;re now done with the same UI (Image Registries):

But the keys and commands in the doc are no longer relevant with the new UI. See the screenshot above for reference. And I think we can still host the doc at https://www.eclipse.org/codewind/dockerregistry.html

[sishida]

Got confirmation from @j-c-berger that this issue is good to close. :)