search

eclipse-archived / codewind

The official repository of the Eclipse Codewind project
https://codewind.dev
Eclipse Public License 2.0
114 stars 44 forks source link

Whitelist VSCode app link from the URL validation from build.sh #1261

Open sghung opened 4 years ago

sghung commented 4 years ago

When running build.sh I see: URL vscode:extension/IBM.codewind' Name this link' Parent URL http://localhost:8765/codewind/mdt-vsc-getting-started.html, line 615, col 36 Base http://localhost:8765/codewind/ Real URL vscode:extension/IBM.codewind Info The URL is outside of the domain filter, checked only syntax. Result Error: URL is unrecognized or has invalid syntax

vscode:extension/IBM.codewind is a valid URL to launch vscode and it should be whitelisted to avoid seeing this error when running the URL validation.

travis1111 commented 4 years ago

@sghung please assign to me :-)

sghung commented 4 years ago

Someone had the same issue as us: https://github.com/linkchecker/linkchecker/pull/180/files

They had to modify the linkchecker source to handle it. I checked out linkchecker and created my own docker image where vscode was added. As a result, we don't see the checker complain about vscode:extension anymore

jcockbain commented 4 years ago

/pipeline verify

@sghung can this be closed?

codewind-bot commented 4 years ago

@sghung - this issue is now ready to be verified.