search

eclipse-archived / codewind

The official repository of the Eclipse Codewind project
https://codewind.dev
Eclipse Public License 2.0
113 stars 45 forks source link

Investigate upgrade from CLI framework v1 -> CLI framework v2 #2235

Open liamchampton opened 4 years ago

liamchampton commented 4 years ago

Description of the enhancement: We currently use v1 of urfav/cli. Since creating the CLI, v2 has been released. We should investigate the changes/upgrades/deprecations and see if we can make better use of this and its new features.

Repository: https://github.com/urfave/cli Changelog: https://github.com/urfave/cli/blob/master/docs/CHANGELOG.md

tobespc commented 4 years ago

first step is to get cwctl to use go modules rather than use dep dependancy package manager

tobespc commented 4 years ago

This may well be something we have to do to properly work with the odo2 cli

markcor11 commented 4 years ago

At this time I don't think we require the features in the V2 version of the third party cli framework. We are currently using v1.21.0 and will assess moving to v1.22.4 to pick up any bug fixes as part of a general update. Moving to Go Modules is worthwhile though.

tobespc commented 4 years ago

agreed, the module change is sufficient for now