eclipse-archived / codewind

The official repository of the Eclipse Codewind project
https://codewind.dev
Eclipse Public License 2.0
114 stars 44 forks source link

SVT:User need better message when adding template repo with yaml file extension #2837

Open jagraj opened 4 years ago

jagraj commented 4 years ago

Codewind version: 0.11.0 OS: CoreOS/OpenShift 4.3

Che version: 7.9.3 , CodeReady Workspaces 2.1.1 IDE extension version: 0.11.0 IDE version: CRW 2.1.1/Che 7.9.3 Kubernetes cluster: OpenShift 4.3

Description: When adding Kabanero stacks repo with yaml file extension that we display 400 error to the user and we need to display better error message to the user saying "json" file expecting not "yaml" file.

Steps to reproduce:

  1. Install Codewind from Eclipse Che/CRW.
  2. Add Kabanero repo from Template manager. (https://github.com/kabanero-io/kabanero-stack-hub/releases/download/0.8.1/kabanero-stack-hub-index.yaml).
  3. You get message "Error adding new template source: Error: PFE responded with status code 400"

Screen Shot 2020-05-01 at 12 37 58 PM

Workaround:

jagraj commented 4 years ago

/area vscode-ide

tetchel commented 4 years ago

Agreed, the user should never have to see a status code. This error message is provided by cwctl which gets it from Portal. This bug is similar to https://github.com/eclipse/codewind/issues/2277

jcockbain commented 4 years ago

/assign /pipeline In Progress

jcockbain commented 4 years ago

After https://github.com/eclipse/codewind-installer/pull/431 the error returned shouldn't be the one described above but something like:

image

Investigating now however why the parameter for me is null. cwctl is now correctly parsing the error from PFE, but that error message has the null in it.

jcockbain commented 4 years ago

/pipeline Review/QA

jcockbain commented 4 years ago

@jagraj - the fix has now been merged to PFE. Could you verify when you get a chance please?

mattcolegate commented 4 years ago

/pipeline verify

codewind-bot commented 4 years ago

@jagraj - this issue is now ready to be verified.