eclipse-archived / codewind

The official repository of the Eclipse Codewind project
https://codewind.dev
Eclipse Public License 2.0
114 stars 44 forks source link

CWCTL test.sh incudes test dirs in test #2898

Open mattcolegate opened 4 years ago

mattcolegate commented 4 years ago

CWCTL pkg/ has no tests defined

Codewind version: latest OS: All

Che version: N/A IDE extension version: N/A IDE version: N/A Kubernetes cluster: N/A

Description of the enhancement:

Test.sh includes test directories in it's test run when it should leave them untested.

$ ./test.sh
ok      github.com/eclipse/codewind-installer/cmd/cli   2.513s
?       github.com/eclipse/codewind-installer/pkg/actions       [no test files]
ok      github.com/eclipse/codewind-installer/pkg/apiroutes     (cached)
?       github.com/eclipse/codewind-installer/pkg/appconstants  [no test files]
ok      github.com/eclipse/codewind-installer/pkg/config        (cached)
ok      github.com/eclipse/codewind-installer/pkg/connections   (cached)
ok      github.com/eclipse/codewind-installer/pkg/desktop_utils (cached)
ok      github.com/eclipse/codewind-installer/pkg/docker        2.158s
?       github.com/eclipse/codewind-installer/pkg/errors        [no test files]
ok      github.com/eclipse/codewind-installer/pkg/gatekeeper    (cached)
?       github.com/eclipse/codewind-installer/pkg/globals       [no test files]
ok      github.com/eclipse/codewind-installer/pkg/project       (cached)
ok      github.com/eclipse/codewind-installer/pkg/remote        (cached)
?       github.com/eclipse/codewind-installer/pkg/remote/kube   [no test files]
ok      github.com/eclipse/codewind-installer/pkg/sechttp       (cached)
ok      github.com/eclipse/codewind-installer/pkg/security      (cached)
?       github.com/eclipse/codewind-installer/pkg/test  [no test files]
ok      github.com/eclipse/codewind-installer/pkg/utils 84.924s
?       github.com/eclipse/codewind-installer/resources/test/go-project [no test files]

Proposed solution:

Remove /pkg/test and resources/test/go-project from test runs.

mattcolegate commented 4 years ago

/kind test /area portal