eclipse-archived / codewind

The official repository of the Eclipse Codewind project
https://codewind.dev
Eclipse Public License 2.0
114 stars 44 forks source link

Link to 'VS Code Marketplace' is broken #346

Open josephca opened 5 years ago

josephca commented 5 years ago

Codewind version: OS:

Che version: IDE extension version: IDE version: Kubernetes cluster:

Description: The link in the README.md is broken. https://github.com/eclipse/codewind-openapi-vscode/blob/master/README.md

  1. Installing. (OPTIONAL) Install Codewind for VS Code from the VS Code Marketplace or by searching for Codewind in the VS Code Extensions view.

The link should point to https://marketplace.visualstudio.com/items?itemName=IBM.codewind instead of https://marketplace.visualstudio.com/items?itemName=IBM.codewind-tools

Similar broken link on https://github.com/eclipse/codewind-openapi-eclipse/blob/master/README.md

Install the Codewind OpenAPI Tools from the Eclipse Marketplace. should point to

https://marketplace.eclipse.org/content/codewind-openapi-tools

Steps to reproduce:

Workaround:

keithchong commented 5 years ago

No, it is supposed to point to Codewind for VS Code

The link should be https://marketplace.visualstudio.com/items?itemName=IBM.codewind

They changed the link from

https://marketplace.visualstudio.com/items?itemName=IBM.codewind-tools

josephca commented 5 years ago

No, it is supposed to point to Codewind for VS Code

The link should be https://marketplace.visualstudio.com/items?itemName=IBM.codewind

They changed the link from

https://marketplace.visualstudio.com/items?itemName=IBM.codewind-tools

LOL. I changed the description with the correct link while you wrote a comment. :)

keithchong commented 5 years ago

At least the description provides an alternative way to show the Codewind extension "or by searching for Codewind in the VS Code Extensions view."

After discussing with Joseph some more, it looks like the broken link was not detected until now. We will change this post 0.3.0.

josephca commented 5 years ago

@tetchel Please close this if it is fixed by #432. Thanks,

tetchel commented 5 years ago

No, separate issue

sghung commented 4 years ago

@josephca I think this issue has been fixed now, can you confirm and close?