Hardcoded version in framework bundle

eclipse-archived / concierge

Eclipse Concierge™ project

https://www.eclipse.org/concierge/

Eclipse Public License 1.0

33 stars 22 forks source link

Hardcoded version in framework bundle #60

Open svilenvul opened 6 years ago

svilenvul commented 6 years ago

I am referring to:

https://github.com/eclipse/concierge/blob/9399f771aa6b327612e45ce277c793929c1bbc2b/framework/org.eclipse.concierge/src/org/eclipse/concierge/Concierge.java#L149

It is more interesting how this affects the displayed bundle version:

hardcoded-version

You can imagine how difficult was to find where this "snapshot" version came from, as it is not available in any repository... :-)

tverbele commented 6 years ago

If I recall correctly this thing is supposed to be set by the build tool? @JochenHiller ?

rellermeyer commented 6 years ago

This should be set by the build tool but I think currently it is not. For now, I will hardcode it to 5.1.0-SNAPSHOT and look into ways to have it automatically synchronized with the version info (currently in a version.txt file).