search

eclipse-archived / packagedrone

Eclipse Package Drone
http://eclipse.org/package-drone
Eclipse Public License 1.0
66 stars 39 forks source link

Extract all entries from the Manifest #116

Closed peterjeschke closed 6 years ago

peterjeschke commented 6 years ago

This addition adds all keys from the Manifest file as metadata.

The use case for this is to have (for example) more filter options available for the cleaner aspect. We have multiple custom entries in our manifests that we want to use as parameter for the cleaner, but the fullManifest entry doesn't cut it for us because we also have entries that might change randomly.

This can be improved by making this independent from the OSGI-aspect because Manifests exist in non-osgi JARs, too. But I decided to just put it where the fullManifest metadata is read.

ctron commented 6 years ago

Thanks for the PR! I really like this.

But as you mentioned, it is actually independent of OSGi and I think it would be better if this would be a separate aspect.

Would it be possible for you to provide this in a separate aspect? I think it is ok to keep it in the same bundle.