search

eclipse-archived / packagedrone

Eclipse Package Drone
http://eclipse.org/package-drone
Eclipse Public License 1.0
66 stars 39 forks source link

Fix bundles with dir-shape have needed instruction in content.xml (#128) #129

Closed doggy-dev closed 6 years ago

doggy-dev commented 6 years ago

When a bundles has the Eclipse-BundleShape: dir manifest entry the installable unit in content.xml the touchpointData must have

true

Otherwise when tycho builds a product the bundle is not beeing extracted.

ctron commented 6 years ago

Thanks for the PR. This looks good to me.

All that is requires is that you sign the Eclipse Contributor Agreement (ECA) and add the Signed-off-by: footer entry in the git commit, after you signed the agreement.

Let me know if you need any help with that.

doggy-dev commented 6 years ago

I think I'm done. I also rebased the the commits on master.

ctron commented 6 years ago

Could you please rebase the branch. This should fix the issues with travis.

doggy-dev commented 6 years ago

Please don't merge yet. I think there is a bug in my code.

doggy-dev commented 6 years ago

Should be fixed now. Sorry about that.