search

eclipse-archived / packagedrone

Eclipse Package Drone
http://eclipse.org/package-drone
Eclipse Public License 1.0
66 stars 39 forks source link

Add support for custom charset in header data #135

Closed Monichev closed 5 years ago

Monichev commented 5 years ago

I would like to add a possibility of charset customization in header. Sometimes I have to create RPMs for platforms where UTF-8 is not supported. And using non Latin characters results in broken symbols.

ctron commented 5 years ago

Thanks for the PR. I think it makes sense having this functionality. However I am not a big fan of system properties.

I think it would make sense to pass along the Charset of choice, defaulting to UTF-8.

In any case you would also need to sign the Eclipse Contributor Agreement: https://www.eclipse.org/legal/ECA.php … let me know if you need any help with this.

Monichev commented 5 years ago

I think it would make sense to pass along the Charset of choice, defaulting to UTF-8.

I moved this parameter to BuilderOptions class. Is it Ok?

https://www.eclipse.org/legal/ECA.php … let me know if you need any help with this.

Yes, I need your help. I've already signed the ECA. The ECA VALIDATION TOOL shows that my e-mail address has ECA. But still ip-validation stage is failed.

ctron commented 5 years ago

Yes, I need your help. I've already signed the ECA. The ECA VALIDATION TOOL shows that my e-mail address has ECA. But still ip-validation stage is failed.

To me it looks like you are missing the Signed-off-by entry in both git commits.

You need to amend both commits (or maybe squash them) and force push.

… and I guess it would be time for a builder pattern, rather than adding constructors :grin: but that is not an issue of this PR.

ctron commented 5 years ago

Thanks for the PR! :+1: