search

eclipse-archived / packagedrone

Eclipse Package Drone
http://eclipse.org/package-drone
Eclipse Public License 1.0
66 stars 39 forks source link

squid:SwitchLastCaseIsDefaultCheck - switch statements should end wit… #66

Closed m-ezzat closed 8 years ago

m-ezzat commented 8 years ago

This pull request is focused on resolving occurrences of Sonar rule squid:SwitchLastCaseIsDefaultCheck - "switch" statements should end with a "default" clause

You can find more information about the issue here: https://dev.eclipse.org/sonar/coding_rules#q=squid:SwitchLastCaseIsDefaultCheck

Please let me know if you have any questions.

M-Ezzat

ctron commented 8 years ago

If you make any changes for the first time in a file, please add yourself in the copyright headers section.

The check on sonar you are referencing also says that either appropriate action should be taken or a comment should be in place.

So if that changes is about enhancing code quality, and not just about scores, then there should be a comment in place. At some locations I guess even the throw can be pulled up in the default section, instead of the break.

ctron commented 8 years ago

I know that for some locations it may be hard for you to see what the default code path should do. If you have questions, let me know and will try to help you.

ctron commented 8 years ago

Closing out for now.