Documentation and base implementation of handleConfigurationUpdate should be improved

[kaikreuzer]

The example code for handleConfigurationUpdate does a

dispose();
updateConfiguration(configuration);
initialize();

This is imho not the way that implementations should do it (see my https://github.com/openhab/openhab2-addons/pull/650#discussion_r52759852). If they have no better logic, they should simply use the super implementation in BaseThingHandler.

Within BaseThingHandler.updateConfiguration, callback.thingUpdated() is called - I wonder why this isn't instead only calling callback.configurationUpdated()?

[kaikreuzer]

@sbussweiler Could you have a look at this? Am I missing something regarding the base implementation?

[kaikreuzer]

@sbussweiler Ping :-)

[sbussweiler]

We will clarify the impact offline ;-)

[sbussweiler]

As we discussed, BaseThingHandler.updateConfiguration() should also call callback.configurationUpdated(). I will update the implementation and the documentation.

[markusjw]

What if a binding programmer wants to override handleConfigurationUpdate(), but mainly use the suggested code of BaseThingHandler? The variable callback is private. What should an overriding method do to fire all necessary notifications?