eclipse-archived / smarthome

Eclipse SmartHome™ project
https://www.eclipse.org/smarthome/
Eclipse Public License 2.0
861 stars 784 forks source link

Paper UI does not show thing type UID #3284

Open markusjw opened 7 years ago

markusjw commented 7 years ago

If I have seen that correctly, the Paper UI does at no place show the thing type UID of a thing.

It shows the thing type label and description and the thing UID. But for any of these values there are reasons why they might not necessarily contain information about the actual thing type UID.

Shouldn't a field for the thing type UID be added to the thing page?

sjsf commented 6 years ago

They're shown in the overview list:

image

Doesn't this suffice? If you think it would be of particular value to have it on the Thing's detail page repeated, feel free to re-open this issue.

kaikreuzer commented 6 years ago

@sjka: Isn't that the ThingUID and not the ThingTypeUID?

sjsf commented 6 years ago

Ouch, my bad...!

Pavion commented 6 years ago

Isn't ThingTypeUID always the first part of ThingUID?

Looking at my hue Lamp: image

ThingUID: hue:0210:0017822a41d4:13 ThingTypeUID: hue:0210

openHAB project even states it explicit: Thing <binding_id>:<type_id>:<thing_id>. It may be different with Eclipse though.

markusjw commented 6 years ago

As far as I know, ESH doesn't require that. Which is good, because the binding I'm working on (not public yet) doesn't follow this convention completely.

There is a reason (and it is a matter of principle): The ThingTypeUID can change if the thing is updated to a different ThingType (e.g. because of changes to the channels). The ThingUID, however, never changes, so it shouldn't contain the ThingTypeUID, otherwise the included information might get incorrect.