BasicUI: Feature Request for optional Title Bar

eclipse-archived / smarthome

Eclipse SmartHome™ project

https://www.eclipse.org/smarthome/

Eclipse Public License 2.0

862 stars 783 forks source link

BasicUI: Feature Request for optional Title Bar #3296

Open Auto-Mark opened 7 years ago

Auto-Mark commented 7 years ago

For some of my sitemaps it would be nice not to have a title bar displayed. Maybe an option can be introduced to ommit the title bar.

So instead of sitemap demo label="My home automation" {... it could be sitemap demo nolabel {... or even just sitemap demo {...

Example screenshot taken from http://docs.openhab.org/configuration/sitemaps.html

clipboarder

hreichert commented 7 years ago

Let me take a look into this. @sjka Are you guys working here with Assigness, or are the issues floating?

sjsf commented 7 years ago

Unfortunately only committers can assign people - github doesn't allow such fine-grained permissions. Therefore leaving a comment that you are working on it would be fully sufficient.

hreichert commented 7 years ago

@sjka Ok, thanks for clarification. Github newbie here :)

So, I'm working on this.

hreichert commented 7 years ago

Current implementation is as following.

If a label is defined, it is shown. sitemap demo label="Main Menu" { results in: 845e99d1-eed9-40d0-b878-faa9c0a5df19

If no label is defined, the name of the sitemap is shown. sitemap demo { results in: 4fe1b59f-0a92-4f49-800d-e20b7daaf220

I think this is good and should not be changed.

We can add a attribute header=true/false or hideHeader or something like this: sitemap demo header=false { results in: 26eed76c-2b85-495b-882e-029a25e45e70

But there are a few concerns:

As the BasicUI is not the only UI in the universe, this would be specific to the BasicUI. But maybe other UIs (ClassicUI) can implement a similiar behaviour. Other UIs (Android app) can ignore the attribute.
In the BasicUI and ClassicUI, the "home" button is also in the header. If the whole header is hidden, there would be also no "home" button if someone navigates to a nested group.

Any opinions about this?

ppieczul commented 7 years ago

It may be interesting to know why title bar should be hidden for some of your sitemaps. If this is for example because it looks better on a tablet (but could be still shown on a PC), that might actually be a browser session property (configured through URL), not a sitemap property.

Such situation is in habpanel with kiosk mode that hides the menu that is inconvenient on kiosk type devices but useful elsewhere. Then you add kiosk=on to the URL to hide it.

hreichert commented 7 years ago

Yes, that would be interesting to know. Maybe habpanel is anyway the better solution for @Auto-Mark to achieve his goals.