search

eclipse-archived / smarthome

Eclipse SmartHome™ project
https://www.eclipse.org/smarthome/
Eclipse Public License 2.0
862 stars 786 forks source link

[Paper UI] 404 Not Found in console when adding discovered Things #5609

Open wborn opened 6 years ago

wborn commented 6 years ago

For certain Thing Types a 404 Not Found is logged in the browser console when you add the discovered Things via the Inbox.

This for example occurs with when adding discovered Things of the Astro or LIFX Bindings:

selection_001

So far there seems to be no loss of functionality.

CC @htreu

triller-telekom commented 6 years ago

I can confirm this bug and just had a look on it. This is actually a "missing corner case" in the recently implemented feature in PR https://github.com/eclipse/smarthome/pull/4702

The problem is that in https://github.com/eclipse/smarthome/blob/4e8fcd9d9440f0d026976edeb77c39c364498880/extensions/ui/org.eclipse.smarthome.ui.paper/web-src/js/setup/controllers.setup.js#L68-L69

the config-description UIR is build with the thing-type. In the case of the astro and lifx binding the thing-types do not have a configuration embedded but link to an externally defined one with a separate uri.

To solve this problem one has to enhance the REST interface to also communicate the config-description URI to the PaperUI so it can query the configdescription-regsitry with the correct URI.

In theory one can extend the ThingTypeDTO to include this URI, but I do not want to break anything before the release by touching it now.