search

eclipse-archived / smarthome

Eclipse SmartHome™ project
https://www.eclipse.org/smarthome/
Eclipse Public License 2.0
862 stars 783 forks source link

ProxyServlet #6668

Open tmrobert8 opened 5 years ago

tmrobert8 commented 5 years ago

I haven't the slightest idea who to start this with (or where) - so I though I'd start here.

I have an openHAB binding (NEEO) that stopped working because of a change in ProxyServlet that ESH/openHAB picked up on awhile back. I've followed up on the issue with the equinox people and they have fixed this issue Bug 540970.

To be able to test the issue and see if it's resolved - I need that fix to percolate up to the openHAB snapshots to test (which would need ESH to pickup on the change first)

How do we get the process started for that?

maggu2810 commented 5 years ago

I could be wrong, but the proxy servlet the bug report is about is org.eclipse.equinox.http.servlet.internal.servlet.ProxyServlet. What is the relationship between ProxyServlet of "equinox" and the ESH one?

tmrobert8 commented 5 years ago

@maggu2810 Thanks for getting back to me - this may be my misunderstanding. Take a look at #6486 (which was the original bug that @kaikreuzer closed).

The NEEO binding is using httpservlet (jetty->equinox). In my manifest file - I'm simply importing "org.eclipse.jetty.http".

Here's the key part of this - I don't know where it's importing the jar from. I always assumed (bad I know) that the source of that import was something in ESH/openHAB since I don't include it directly (just magically pulls it in).

Wherever I'm getting it from - the version I got included the bug that I reported earlier and that bug has now been fixed and I need to get that source jar updated to the latest to include/text the fix.

I kinda assumed (as I stated) that it was coming from ESH/openHAB somewhere and this issue was my starting point.

Please let me know if I'm wrong on that and where I should go from here..

maggu2810 commented 5 years ago

I don't know if I get you right...

In ESH there is a bundle org.eclipse.smarthome.ui. That bundle contains for example that classes:

So, we depend on Jetty stuff. Jetty itself does not depend on Equinox.

There exist also a class org.eclipse.equinox.http.servlet.internal.servlet.ProxyServlet.

This class is part of the bundle org.eclipse.equinox.http.servlet.

ESH itself does not depend on that bundle and I don't see any place it is used.

wborn commented 5 years ago

Do you have this issue when starting the runtime in Eclipse or also when using your code in an actual distribution such as openHAB @tmrobert8 ?

Both SmartHome-Runtime.launch and openHAB_Runtime.launch have as one of the selected_target_plugins org.eclipse.jetty.osgi.httpservice.

This bundle imports org.eclipse.equinox.http.servlet.